posit-dev / posit-dev/commons

Take a pass at dark mode compatible styling

Open
#178 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
44
Forks
1
Avg merge
1d 7h
Merged PRs (30d)
142

Description

In #169, I noticed some of the styling that commons adds to shinychat doesn't take dark mode into consideration. In particular, the disabled button color, provenance pills, and possibly more.

Note that this will become more discoverable since page_chat() makes it much easier to add a dark mode toggle, which will respect user preferences on load

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect the styling that commons adds to shinychat, starting with the disabled button color and provenance pills mentioned in the issue. Check how page_chat() enables a dark mode toggle and verify that these styles, along with any related styling found during review, remain readable and compatible in dark mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.