Eliminate ad hoc creation of function completion items
Open
@jennybc is already working on this.
Since Jun 24, 2025.
area: language server
enhancement
- Dominant language
- Rust
- Stars
- 337
- Forks
- 32
- Avg merge
- 8d 17h
- Merged PRs (30d)
- 11
Description
Loose end discovered while working on #819:
completion_item_from_assignment(), which is used for document completions, hand crafts a function completion item, which means it doesn't benefit from all the smarts in completion_item_from_function().
I actually found this problem when writing tests for #819, because my first crack at it was with a user-defined function in the global environment. I wondered why things weren't working! This issue is a reminder to me to come back and route this through completion_item_from_function() and to look hard for any other instances of similar.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.