posit-dev / posit-dev/ark

R: Panic if we shutdown while waiting for an `input_reply`

Open
#694 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
337
Forks
32
Avg merge
8d 17h
Merged PRs (30d)
11

Description

Reprex:

  • menu(c("a", "b"))
  • Shut down the session

We get a structured error message that suggests we were not expecting this to ever occur, but maybe we should special case whatever is happening here to allow the shutdown.

It puts us in a state where we can't get into a new R session without a full shutdown of Positron, which is not great.

https://github.com/posit-dev/ark/assets/19150088/2070e5e0-efd5-4a9c-b84c-c3c86c13d1ef

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with menu(c("a", "b")) and shut down the session while it waits for input_reply. Trace the input_reply and shutdown handling, then verify that shutdown completes cleanly and a new R session can start without restarting Positron; no file or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, rust
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.