Make the `Originator` a global rather than passing it through arguments
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 337
- Forks
- 32
- Avg merge
- 8d 17h
- Merged PRs (30d)
- 11
Description
-
Can automatically be applied to "nested" stdin requests that happen within an execute request
-
Can be applied to stdin requests that happen from
call_frontend_method()when we move that method to theUiComm. Currently, having the originator as an argument makes this move difficult because we can't easily get the originator over to theUiComm(we could potentially askR_MAINfor it, but that's a little gross). -
We already use a somewhat similar approach when we do IOPub busy/idle through having a "context" for each IOPub message
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how Originator is currently passed through execute and stdin request paths. Compare that flow with the existing IOPub busy/idle context approach, including the planned call_frontend_method() move to UiComm. Done means nested stdin requests and UiComm-originated requests can obtain the originator without passing it through arguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100