Make `db.package_by_name()` and `db.root_by_package()` backed by Salsa queries
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 337
- Forks
- 32
- Avg merge
- 8d 17h
- Merged PRs (30d)
- 11
Description
See https://github.com/posit-dev/ark/pull/1287#discussion_r3466227660
I think we started with file_by_path(), which can't be a query because FilePath is not a Salsa key, but that reason doesn't apply to package-by-name (if we make it take a Name instead of &str) and root-by-package.
Idea is to make package_by_name_query() and root_by_package_query() that underly these into queries
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating db.package_by_name(), db.root_by_package(), and the related package_by_name_query() and root_by_package_query() APIs, then read the Salsa query discussion in PR #1287. Done means both lookups are backed by Salsa queries while preserving their existing behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 64/100