posit-dev / posit-dev/air

Air does not do proper styling of box imports

Open
#257 6 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
446
Forks
32
Avg merge
16h 48m
Merged PRs (30d)
1

Description

The below usage of box is already formatted correctly.

box::use(
  app / logic / backend / api_wrappers[client],
  app / logic / backend / client[
    create_client,
  ],
)

However when air formats it the result is:

box::use(
  app / logic / backend / api_wrappers[client],
  app /
    logic /
    backend /
    client[
      create_client,
    ],
)

Is this intended behavior? We rely heavily on using box imports in our projects and the above would make all our imports very hard to manage and very verbose.

Except for the above - we are loving Air so far!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported box::use formatting in Air with the nested app / logic / backend / client import shown in the issue. Trace how the formatter handles these imports and confirm that the completed behavior preserves the compact slash-chain style while still formatting the import contents correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.