posit-dev / posit-dev/air

Magic new lines should probably work when there are 0 arguments

Open
#129 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
446
Forks
32
Avg merge
16h 48m
Merged PRs (30d)
1

Description

Image

I this case I had 3 allowed_precisions_* vectors, all of which were expanded, but the last one happened to be empty for this particular function call. I had written it in expanded form to better align with the other 2 expanded ones.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the attached example and locating the formatter logic for expanded allowed_precisions_* vectors and magic new lines. Reproduce the case where the final vector has zero arguments, then verify that the empty expanded vector is handled consistently with the other expanded vectors.

Written by the indexing model from the issue text.

Assessment

Tech stack
r, rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.