Columns don't expand properly in INSERT SELECT statements
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8.7k
- Forks
- 374
- Avg merge
- 11d 16h
- Merged PRs (30d)
- 1
Description
In this case, ${uniqueColumns} should be a list of columns to insert data from the select statement but the generated sql statement uses the values syntax.
Typescript:
const uniqueColumns = ['uniqueId']
await sql`INSERT INTO "schema".${stagingRelation} ${uniqueColumns}
SELECT ${uniqueColumns} FROM "schema".${dataRelation}
WHERE col IN ${sql(col)} ON CONFLICT DO NOTHING`;
Generated SQL statement:
INSERT INTO "schema"."table_staging" ("0","1","2","3","4","5","6","7")values($1,$2,$3,$4,$5,$6,$7,$8) SELECT "uniqueId" FROM "schema"."table" WHERE col IN ($9,$10,$11) ON CONFLICT DO NOTHING
Best I can tell this is caused by this line of code. Let me know if there is anything I can do to help.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/types.js line 69 and reproduce the issue with the TypeScript example using a single uniqueColumns entry. Compare the generated INSERT SELECT SQL with the expected column-list form; done means the columns are not expanded into indexed values and the resulting statement is valid.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, postgresql, typescript
- Domain
- database
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100