Empty array should probably produce invalid sql and throw
Open
Nobody has claimed this yet.
v4
- Dominant language
- JavaScript
- Stars
- 8.7k
- Forks
- 374
- Avg merge
- 11d 16h
- Merged PRs (30d)
- 1
Description
The sql call below returns an empty array to the rows variable. I'm not sure how the query is being translated exactly (is there a way to see the generated query?) but I think throwing would be more useful than gracefully returning an empty array.
const arr = []
const rows = await sql`select *
from generate_series(1, 5) i
where i not in ${sql(arr)};`
await sql.end()
console.log(rows)```Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the JavaScript reproduction against PostgreSQL and investigate how sql(arr) is translated, including whether the generated query can be inspected. Done means the empty-array case produces invalid SQL and throws instead of returning an empty rows array, with relevant tests added or updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, postgresql, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100