Caught errors within transactions still thrown as uncaught
Open
Nobody has claimed this yet.
v4
- Dominant language
- JavaScript
- Stars
- 8.7k
- Forks
- 374
- Avg merge
- 11d 16h
- Merged PRs (30d)
- 1
Description
maybe it's just me, but i find this surprising:
sql.begin((tsql) =>
tsql`select * from nonexistent`
.then(console.log)
.catch((ex) => Promise.resolve('no no it's fine everything is okay'))
).catch((ex) => console.log('got:', ex));
// got: PostgresError: relation "nonexistent" does not exist
i feel like this should not result in an error at all. i handled it, right?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the sql.begin transaction entry point and the promise chain shown in the issue. Trace how the error from the nonexistent relation is propagated after the inner catch, then verify the behavior with an equivalent transaction and query. Done means a handled inner error no longer causes the outer transaction promise to reject unexpectedly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs, postgresql
- Domain
- backend, databases
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100