JSONB field name incorrectly handled by `sql()`
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8.7k
- Forks
- 374
- Avg merge
- 11d 16h
- Merged PRs (30d)
- 1
Description
Take a simple query like
sql`
SELECT * FROM "Example"
WHERE
somejsonb->>'someField' = foo;
`
When built dynamically:
// fieldName → somejsonb->>'someField'
// val → 'foo'
sql`
SELECT * FROM "Example"
WHERE
${sql(fieldName)} = ${val};
`
fieldName is incorrectly quoted as "somejsonb->>'someField'" (it should be "somejsonb"->>'someField')
Manually wrapping somejsonb in double-quotes results in an extra set of quotes: ""somejsonb"->>'someField'"
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the dynamic query using sql(fieldName) with the JSONB expression shown in the issue, then trace the sql() interpolation and identifier-quoting entry point. Done means the generated SQL quotes the JSONB column name without quoting the whole expression, while preserving the value interpolation and avoiding extra quotes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, postgresql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100