popcodeorg / popcodeorg/popcode
Preview component should not rely on prop change detection to send expressions to frame
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 191
- Forks
- 143
- Avg merge
- 4d 11h
- Merged PRs (30d)
- 5
Description
Currently the <Preview> component looks for changes in the list of console expressions to determine what if any expressions to send to the frame for evaluation. Component behavior that depends on both previous and current state is considerably harder to reason about and should be avoided. Instead, console entries should have state indicating whether they have been sent to a frame for evaluation; this should be updated synchronously after the frame initially posts the expression. The <Preview> component should simply consume all entries that are not marked as evaluation started.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the component and the console-entry state used when the frame initially posts an expression. Identify where entries are marked after evaluation begins, then update the flow so Preview consumes entries not marked as started. Done means expression delivery no longer depends on comparing previous and current prop values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100