pnpm / pnpm/action-setup

action-setup should print the version of pnpm that it picked

Open
#238 0 comments 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.3k
Forks
217
Avg merge
8h 42m
Merged PRs (30d)
1

Description

v5 produced output like

Run pnpm/action-setup@v5
  with:
    dest: ~/setup-pnpm
    run_install: null
    cache: false
    cache_dependency_path: pnpm-lock.yaml
    package_json_file: package.json
    standalone: false
  env:
    APP_ID: 1013567
    CLIENT_ID: Iv23liXTAsX4IYm9H6lc
    DATABASE_URL: file:./test.db
Running self-installer...
  (node:2245) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
  (Use `node --trace-deprecation ...` to show where the warning was created)
  Progress: resolved 1, reused 0, downloaded 0, added 0
  Packages: +1
  +
  Progress: resolved 1, reused 0, downloaded 1, added 1, done
  
  dependencies:
  + pnpm 10.30.2 (10.33.2 is available)
  
  Done in 764ms
Installation Completed!

v6 produces output like

Run pnpm/action-setup@v6
  with:
    dest: ~/setup-pnpm
    run_install: null
    cache: false
    cache_dependency_path: pnpm-lock.yaml
    package_json_file: package.json
    standalone: false
  env:
    APP_ID: 1013567
    CLIENT_ID: Iv23liXTAsX4IYm9H6lc
    DATABASE_URL: file:./test.db
Running self-installer...
  
  added 5 packages, and audited 6 packages in 2s
  
  2 packages are looking for funding
    run `npm fund` for details
  
  found 0 vulnerabilities
Installation Completed!

This obscures the fact that v6 is ignoring the version specified in the packageManager field of package.json, as reported in #225.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the action-setup entry point and the packageManager field in package.json, then trace how v6 selects and installs pnpm. Compare the installer output with the v5 example and verify that the selected pnpm version is printed and that the packageManager-specified version is not silently ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, nodejs, typescript
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.