pnp / pnp/sp-dev-fx-controls-react

[TreeView] Implement property defaultExpandedChildren on v1 component

Open
#808 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type:enhancement v1
Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Category

[ ] Enhancement

[ ] Bug

[x] Question

Version

1.2

Expected / Desired Behavior / Question

Hello, I am using the TreeView component in SP2019 on-premise (version 1.2 of spfx-controls-react). I would like to implement the behaviour allowed by the property defaultExpandedChildren but this property is only available in version 2.1 of the spfx-controls-react (and I cannot use this version since I am on-premise).
I would like to know if it is feasable to apply the code used for the property defaultExpandedChildren into my old version ? I was thinking about grabing the code from the 2.1 version and modify the JS and TS files used in the node_modules folder but I first would like to know your opinion on this hack ?
Cheers
Thanks!

David

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TreeView implementation and compare the TypeScript and JavaScript files in the v1.2 and v2.1 packages, focusing on defaultExpandedChildren. Determine whether the v2.1 behavior can be adapted to the SP2019-compatible version; done means answering the feasibility question and identifying the relevant compatibility constraints.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.