pnp / pnp/sp-dev-fx-controls-react
FileTypeIcon - some icons are not showing
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[ ] Enhancement
[X] Bug
[ ] Question
Version
3.24.0
Expected / Desired Behavior / Question
We are using FileTypeIcon control with the following parameters:
<FileTypeIcon type={IconType.image} size={ImageSize.small} path={path} />
This should show an icon based on the value passed to path property.
Observed Behavior
Recently we have started seeing 409 Conflict error for some of document extensions:
- https://modernb.akamai.odsp.cdn.office.net/files/fabric-cdn-prod_20210703.001/assets/item-types/16/spo.png
- https://modernb.akamai.odsp.cdn.office.net/files/fabric-cdn-prod_20210703.001/assets/item-types/16/docx.png
PowerPoint, Excel, PDF icons are showing as expected. Above icons had been showing as expected until recently.
Steps to Reproduce
- add FiletypeIcon control with the following properties:
- type
- size
- path
- load the page with the control
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the FileTypeIcon control and reproduce the issue with type, size, and path set as shown. Inspect the requests for spo.png and docx.png, compare them with the working PowerPoint, Excel, and PDF icons, and verify that the affected document extensions load without 409 Conflict errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100