pnp / pnp/sp-dev-fx-controls-react

Missing Chevrons on @pnp/spfx-controls-react/lib/Accordion on version 3.23.0

Open
#2,097 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[X ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.23.0 ]

Expected / Desired Behavior / Question

When trying to understand what was going on, I found an error in this code:
node_modules@pnp\spfx-controls-react\lib\controls\accordion\Accordion.js

Lines 34 and 35

    collapsedIcon.iconName = props.collapsedIcon || 'CheveronRight';
    expandedIcon.iconName = props.expandedIcon || 'CheveronDown';

Chevron is misspelled this should be:

    collapsedIcon.iconName = props.collapsedIcon || 'ChevronRight';
    expandedIcon.iconName = props.expandedIcon || 'ChevronDown';
Observed Behavior

When rendering the According in a SPFx web part the the ChevronRight or ChevronDown does not render.

Steps to Reproduce

Add an Accordion to a SharePoint SPFx 1.22.1 Project.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Accordion implementation corresponding to node_modules/@pnp/spfx-controls-react/lib/controls/accordion/Accordion.js, especially lines 34–35, and verify the reported icon names. Reproduce the issue in a SharePoint SPFx 1.22.1 project with an Accordion, then confirm the chevrons render correctly after the correction.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.