pnp / pnp/sp-dev-fx-controls-react
[spfx 1.22] Missing styling on several controls when upgrade to spfx 1.22
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [ 3.23 ]
I am not sure whether other people has the same problem or it is just my own environment issue.
I noticed that many controls (e.g. Accordion,Taxonomy Picker ,Carousel ,maybe more controls has this issue) have missing styling problem after I upgrade my spfx project to v1.22.1 .
Observed Behavior
- TaxonomyPicker lost styling
- RichText lost styling
- FolderPicker lost styling
- Carousel lost styling
- Accordion lost styling
The accordion should be like this
My feeling is that, it looks like all controls which uses "module.scss" file as styling have this issue when upgrade to v1.22.1.
As I said, I am not sure whether it is my own environment issue or other people also have this issue.
Please comment if you can reproduce this problem.
Steps to Reproduce
- Generate a new webpart spfx project via using latest m365-cli , to make sure it uses heft and spfx version is v1.22.1
- Add the controls I mentioned (just copy those sample code in the https://pnp.github.io/sp-dev-fx-controls-react/controls )
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue in a new SPFx 1.22.1 webpart generated with the latest m365-cli, using the sample code from the Accordion, TaxonomyPicker, RichText, FolderPicker, and Carousel control pages. Check the controls that use module.scss files and compare their rendered styling with the documented examples; done means the affected controls regain their expected styling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100