pnp / pnp/sp-dev-fx-controls-react

richtext fire change event when I'm opening the color selector.

Open
#2,073 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.23.0 ]

I'm selecting text, click the three dots menu, the panel open, I'm clicking on the color selector and boom! it fires a change event and then display the color choice. And yes, the content is changed, a span tag with style is now surrounding the selected text.

It should not fire this event until the color is selected.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in the rich text control using version 3.23.0: select text, open the three-dots menu, and open the color selector. Trace the color selector's change handling and verify that opening it does not alter the content or fire a change event; the event should occur only after a color is selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.