pnp / pnp/sp-dev-fx-controls-react

Formula evaluation of formula using len() function not working properly

Open
#1,985 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[x] Bug

Version

Please specify what version of the library you are using: [ 3.20.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Proper evaluation of validation formula =len(internalColumnName)>6

Observed Behavior

Considers strings with length >6 to be not valid.

Steps to Reproduce

Add column with validation formula =len(internalColumnName)>6, check how it does not consider strings that are longer than 6 as valid even though the default SharePoint form does

https://github.com/pnp/sp-dev-fx-controls-react/blob/5d17c0393e79ff3cb06996480ed07f28e262334c/src/common/utilities/FormulaEvaluation.ts#L538

Here length is used as length function, but it should be len as far as I understand (https://support.microsoft.com/en-us/office/len-function-038f2e0d-57d3-4f35-ae74-9a79d66e8fc2)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at src/common/utilities/FormulaEvaluation.ts around line 538, where the reported formula function is handled. Reproduce the issue with =len(internalColumnName)>6 and compare its result with the default SharePoint form. Done means strings longer than six characters are accepted as valid by the evaluator.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.