pnp / pnp/sp-dev-fx-controls-react
Icons not displayed in FilePicker when using german language
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[ ] Enhancement
[x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [3.20.0]
Expected / Desired Behavior / Question
Icons are displayed when using the FilePicker component
Observed Behavior
When using the compact or list view of the FilePicker component the icons are not displayed if using german language (and a lot other languages)
The "FolderIconUrl" in https://github.com/pnp/sp-dev-fx-controls-react/blob/master/src/loc/de-de.ts is pointing to a non existing svg ("https://spoprod-a.akamaihd.net/files/odsp-next-prod_2019-01-11_20190116.001/odsp-media/images/itemtypes/20/folder.svg")
Thanks!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/loc/de-de.ts and inspect the FolderIconUrl used by the FilePicker. Check the compact and list views with German selected, and compare the referenced icon URL with the available locale configuration. Done means folder and file icons render in both views for German and the broken reference is corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend, localization
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 78/100