pnp / pnp/sp-dev-fx-controls-react
[PeoplePicker] defaultSelectedUsers property - enable possible ID selection for security groups
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[x] Enhancement
[x] Question
Version
Please specify what version of the library you are using: [ "@pnp/spfx-controls-react": "^3.20.0"]
Expected / Desired Behavior / Question
As security group names can change, I think it makes sense to be able to select group by ID, instead of by its name. For groups it's even more relevant, as they don't have email property as users do.
It may either be able to check between both name/id or have a separate field for it.
Observed Behavior
defaultSelectedUsers only receives security group name.
Initially, security group support was added in #958, however, only for a name selection, not id.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the PeoplePicker implementation and trace how defaultSelectedUsers handles security-group names; review the earlier security-group work in issue #958. Decide how ID selection should coexist with name selection, then verify that defaultSelectedUsers can select security groups by ID without breaking existing name-based behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100