pnp / pnp/sp-dev-fx-controls-react
ModernTaxonomyPicker: Style problem - term list overflows panel footer
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[ ] Enhancement
[X] Bug
[ ] Question
Version
Please specify what version of the library you are using: [3.19.0]
Expected / Desired Behavior / Question
The buttons in the footer of the picker panel should be not "above" the term list. There should be a clear separation.
Observed Behavior
In a long list, the individual elements are located below the button bar.
Steps to Reproduce
Create a blank SPFx Solution (v1.19.0), add this package, add basic ModernTaxonomyPicker somewhere in the tsx component (example code below). Add valid termSetId for a larger term set. Serve the webpart (via gulp serve), include on SharePoint page and open the "add term panel" of the picker.
For example
import * as React from 'react';
import type { ISimpleMtpSampleProps } from './ISimpleMtpSampleProps';
import { ModernTaxonomyPicker } from '@pnp/spfx-controls-react/lib/ModernTaxonomyPicker';
export default class SimpleMtpSample extends React.Component<ISimpleMtpSampleProps, {}> {
public render(): React.ReactElement<ISimpleMtpSampleProps> {
const {
termId, context
} = this.props;
return (
<section>
<ModernTaxonomyPicker allowMultipleSelections={true}
termSetId={termId}
panelTitle="Select a term"
label={"Test"}
context={context as any}
/>
</section>
);
}
}
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ModernTaxonomyPicker entry point and reproduce the issue using the provided TypeScript sample with a large term set, then serve the SPFx solution with gulp serve. Verify the panel's footer remains separated from the term list when the list is long.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100