pnp / pnp/sp-dev-fx-controls-react

FolderPicker - Improvment to automatically detect URL type

Open
#1,658 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type:enhancement
Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Category

[x] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.15.0]

Expected / Desired Behavior / Question

Raised by #1379, the idea is to enhance the rootFolder.ServerRelativeUrl to automatically detect if it's absolute or not

Observed Behavior

Current version of the control only works with server relative URL. Some additional work has to be done when working with another site collection than the context's one.

Steps to Reproduce
  • Add the FolderPicker control in a SPFx project
  • Set the siteAbsoluteUrl prop to another site collection
  • Try to set the site collection's library with server relative URL

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FolderPicker control and the handling of rootFolder.ServerRelativeUrl, using the issue's SPFx reproduction steps with siteAbsoluteUrl set to another site collection. Done means the control automatically detects whether the library URL is absolute or server-relative and works for the other site collection.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.