pnp / pnp/sp-dev-fx-controls-react
ListView add onUpdateFilter prop
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[X] Enhancement
[ ] Bug
[ ] Question
Version
[ 3.8.0]
Desired Behavior
It would be great if a method was added to the ListView as a property to be called after applying the filter to the list. That would allow you to implement column-based aggregations, for example.
The change is simple but the utility would be high. I attach a couple of images with a proposal to add the property in IListView.d.ts and to make the call in ListView.js. Thank you!
IListView.d.ts
ListView.js
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading IListView.d.ts and ListView.js, as identified in the issue, and locate where the ListView filter is applied. Add the onUpdateFilter property and ensure it is called after filtering so column-based aggregations can respond to the updated list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100