pnp / pnp/sp-dev-fx-controls-react

[FolderPicker] does not support section variations for themes

Open
#1,198 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type:enhancement
Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Category

[X] Enhancement
[ ] Bug
[ ] Question

Version

Please specify what version of the library you are using: [3.7.2]

Expected / Desired Behavior / Question

Support section theme variations in SharePoint and/or apply a custom theme to the control

Observed Behavior

The FolderPicker control does not support theme variations for page sections as it uses SASS for styles and therefore is unable to apply a Theme object to the control itself.

Steps to Reproduce

Use the FolderPicker control in a Web Part that supports section variations and change the theme applied to the section.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the FolderPicker control and its SASS-based styles, then inspect how a Theme object is or is not passed into the control. Reproduce the control in a Web Part with SharePoint section variations and verify that the control reflects the section theme or accepts a custom theme.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, sass, typescript
Domain
design, frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.