pnp / pnp/sp-dev-fx-controls-react

ListItemAttachments Component is failing to re-render while changing itemID props dynamically

Open
#1,166 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted type:enhancement
Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

Bug

Version

"@pnp/spfx-controls-react": "^3.7.0"

Expected / Desired Behavior / Question

I am using List view to show all list items, on click of each item opening fluent UI panel and showing the form to update the details.
While changing items from one to another without closing the Panel its updates item details but fails to update to the attachment. It should update attachment details as well

Observed Behavior

While changing items from one to another without closing the Panel its updates item details but fails to update to the attachment.

Thanks!
Attachment.zip

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ListItemAttachments component and the supplied Attachment.zip reproduction. Reproduce changing itemID between list items while the Fluent UI panel remains open, then inspect how attachment details respond to that change. Done means the attachment details update for the newly selected item without closing the panel.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.