pnp / pnp/sp-dev-fx-controls-react

Adding color or highlights should add classNames instead of inline styles

Open
#1,152 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs: Discussion 🙋
Dominant language
TypeScript
Stars
433
Forks
418
Avg merge
5d 6m
Merged PRs (30d)
19

Description

Category

[ x ] Enhancement

[ ] Bug

[ x ] Question

Version

Please specify what version of the library you are using: [ 3.5.0 ]

Expected / Desired Behavior / Question

If you are reporting an issue please describe the expected behavior. If you are suggesting an enhancement please
describe thoroughly the enhancement, how it can be achieved, and expected benefit. If you are asking a question, ask away!

Observed Behavior

Updating the color and highlights of text will add the inline styles

If we change the text color it will add the inline styles unlike Rich text editor from sharepoint online. So if the Theme look is changed to dark theme, the color is not changing accordingly so sometimes visibility of text becomes almost 0, incase contrast ration is not good.

Is it possible to add classes from office-ui-fabric instead of adding inline colors.

Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name a specific control, file, test, or entry point. Start by locating where color and highlight formatting becomes inline styles in the TypeScript React controls, then investigate the corresponding Office UI Fabric theme-aware class names. Done means formatted text responds correctly when the theme changes without losing its requested color or highlight.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.