pnp / pnp/sp-dev-fx-controls-react
iFrameDialog with /Lists/../NewForm.aspx?env=WebView is not closing when hit Save/Cancel
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 433
- Forks
- 418
- Avg merge
- 5d 6m
- Merged PRs (30d)
- 19
Description
Category
[X ] Bug
[X ] Question
Expected / Desired Behavior / Question
When loading the url /Lists/../NewForm.aspx?IsDlg=1 (showing the classic form definition), hitting save/cancel will close the dialog due to these additional functions. https://github.com/pnp/sp-dev-fx-controls-react/blob/66d8dbed9b61cb51e294b52c90e690c5620665d7/src/controls/iFrameDialog/IFrameDialogContent.tsx#L41
When using the new url /Lists/../NewForm.aspx?env=WebView (for modern forms) these methods are not called anymore.
ps. Modern forms can only be used for newly created lists, lists created in the past (not sure what timeframe) only have the classic form definition.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/controls/iFrameDialog/IFrameDialogContent.tsx around line 41 and compare the handling of the classic IsDlg=1 URL with the modern env=WebView URL. Reproduce Save and Cancel for both form types, then verify that the modern form closes the dialog as the classic form does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100