pnp / pnp/script-samples

Automatic checks on submission

Open
#638 2 comments 0 reactions 1 assignee View on GitHub

@pkbullock is already working on this.

Since Dec 14, 2023.

enhancement generator
Dominant language
PowerShell
Stars
347
Forks
191
Avg merge
5d 16h
Merged PRs (30d)
10

Description

Need to automate the checks. Eg

  • Files are in expected locations and right casing
  • key files, README.md, in assets, preview.png and sample.json
  • sample.json must not be default BUT if it is to support the contributor, its a task for ME.
  • Parts of the Readme needed to be updated (need to expand on detail)
  • telemetry url in right format matches the folder name
  • delete cmdlet have warning in place in the readme file
  • dates are up to date - ensure that dates created/modified are not part of the default template e.g. there is a change.
  • Recent issue the name column in sample.json file shouldn't contain special characters

Ideally, the list shouldnt be a barrier, its more of a helper for me to tweak the submission accordingly (so i don't miss anything) and contributor gets help.

  • For each step thats checked - ensure there is contributor guidance to help the contributor.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.