pnp / pnp/powershell

[BUG] Add-PnPVivaConnectionsDashboardACE can't handle "ThirdParty" ACES

Open
#5,374 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
904
Forks
407
Avg merge
9h 16m
Merged PRs (30d)
10

Description

When I try to instantiate an ACE with Add-PnPVivaConnectionsDashboardACE, if the ACEType is "ThirdParty", the creation fails with an error.

Here's an example CSV file I'm using. Add-PnPVivaConnectionsDashboardACE works fine with 1, 2, and 5, but dies on 3 and 4 with the error:

Add-PnPVivaConnectionsDashboardACE: 
Line |
  12 |      Add-PnPVivaConnectionsDashboardACE `
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Unrecognized Guid format.

I've had this happen with a different set of ACES, and in that instance, only the "ThirdParty" ACE failed as well.

"Order","ACEType","Title","CardSize","Description","JsonProperties"
"1","CardDesigner","Last Incident","Medium","Design a Viva Connections dashboard card with a quick view using available templates.","{""iconProperty"":"""",""templateType"":""image"",""cardIconSourceType"":1,""cardImageSourceType"":1,""cardSelectionAction"":{""type"":""ExternalLink"",""parameters"":{""target"":""https://adaptivecards.io/""}},""numberCardButtonActions"":1,""cardButtonActions"":[{""title"":""Button"",""style"":""positive"",""action"":{""type"":""ExternalLink"",""parameters"":{""target"":""https://adaptivecards.io/""}},""isVisible"":true},{""title"":""Button"",""style"":""default"",""action"":{""type"":""QuickView"",""parameters"":{""view"":""quickView""}},""isVisible"":true}],""quickViews"":[{""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}"",""template"":""{\n  \""type\"": \""AdaptiveCard\"",\n  \""body\"": [\n    {\n      \""type\"": \""TextBlock\"",\n      \""size\"": \""Medium\"",\n      \""weight\"": \""Bolder\"",\n      \""text\"": \""${Text}\"",\n      \""wrap\"": true\n    }\n  ],\n  \""actions\"": [\n    {\n      \""type\"": \""Action.OpenUrl\"",\n      \""title\"": \""View\"",\n      \""url\"": \""${Url}\""\n    }\n  ],\n  \""$schema\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""version\"": \""1.2\""\n}"",""id"":""quickView"",""displayName"":""Default Quick View""}],""currentQuickViewIndex"":0,""title"":""Last Incident"",""primaryText"":""320 days ago"",""description"":""Description text"",""cardDesignerPlusPlusProperties"":{""dataSources"":[{""type"":""Static"",""id"":""cab2ac32-ab7d-4ee4-b435-fe46f2284b35"",""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}""},{""type"":""Static"",""id"":""13bc9e29-f0c4-4885-b32e-b2cd003e7d68"",""displayName"":""Static"",""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}""}],""quickViews"":[],""primaryQuickViewId"":""quickView""},""cardImageCustomImageSettings"":{""type"":1,""altText"":""Image thumbnail preview"",""imageUrl"":""https://cdn.hubblecontent.osi.office.net/m365content/publish/4d4f120a-ec1b-4d99-b327-c735d8f09239/1128737268.jpg""},""imagePicker"":""https://cdn.hubblecontent.osi.office.net/m365content/publish/4d4f120a-ec1b-4d99-b327-c735d8f09239/1128737268.jpg""}"
"2","Shifts","Shifts","Medium","Shows users a preview of their scheduled shifts from the Shifts app in Teams. They can also clock in and out and track break time when the time clock is enabled in Shifts.","{}"
"3","ThirdParty","People","Large","Search and find people within your organization.","{}"
"4","ThirdParty","Praise","Medium","Show gratitude for peers who went above and beyond at work","{""aceData"":{""cardSize"":""Medium""}}"
"5","CardDesigner","M365 Copilot","Medium","Design a Viva Connections dashboard card with a quick view using available templates.","{""iconProperty"":"""",""templateType"":""image"",""cardIconSourceType"":2,""cardImageSourceType"":1,""cardSelectionAction"":{""type"":""ExternalLink"",""parameters"":{""target"":""https://adaptivecards.io/""}},""numberCardButtonActions"":1,""cardButtonActions"":[{""title"":""Button"",""style"":""positive"",""action"":{""type"":""ExternalLink"",""parameters"":{""target"":""https://adaptivecards.io/""}},""isVisible"":true},{""title"":""Button"",""style"":""default"",""action"":{""type"":""QuickView"",""parameters"":{""view"":""quickView""}},""isVisible"":true}],""quickViews"":[{""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}"",""template"":""{\n  \""type\"": \""AdaptiveCard\"",\n  \""body\"": [\n    {\n      \""type\"": \""TextBlock\"",\n      \""size\"": \""Medium\"",\n      \""weight\"": \""Bolder\"",\n      \""text\"": \""${Text}\"",\n      \""wrap\"": true\n    }\n  ],\n  \""actions\"": [\n    {\n      \""type\"": \""Action.OpenUrl\"",\n      \""title\"": \""View\"",\n      \""url\"": \""${Url}\""\n    }\n  ],\n  \""$schema\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""version\"": \""1.2\""\n}"",""id"":""quickView"",""displayName"":""Default Quick View""}],""currentQuickViewIndex"":0,""title"":""M365 Copilot"",""primaryText"":""Your AI assistant for Solbound. Ask anything you like to know"",""description"":""Description text"",""cardDesignerPlusPlusProperties"":{""dataSources"":[{""type"":""Static"",""id"":""c9414ccc-36bb-4279-ab9b-70a3a091a13c"",""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}""},{""type"":""Static"",""id"":""4dd6eb29-79be-4dd7-8fd0-935fa2a14459"",""displayName"":""Static"",""data"":""{\n  \""Url\"": \""http://adaptivecards.io/schemas/adaptive-card.json\"",\n  \""Text\"": \""Hello, World!\""\n}""}],""quickViews"":[],""primaryQuickViewId"":""quickView""},""cardImageCustomImageSettings"":{""type"":1,""altText"":""Image thumbnail preview"",""imageUrl"":""https://spex003.sharepoint.com/sites/Solbound/SiteAssets/SitePages/Dashboard/Copilot.png""},""cardIconCustomIconName"":""hat_graduation"",""iconPicker"":""hat_graduation"",""imagePicker"":""https://spex003.sharepoint.com/sites/Solbound/SiteAssets/SitePages/Dashboard/Copilot.png""}"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Add-PnPVivaConnectionsDashboardACE cmdlet implementation and reproduce the failure using the CSV rows for ACEType ThirdParty. Compare those rows with the working CardDesigner and Shifts entries, then verify that both ThirdParty records can be created without the "Unrecognized Guid format" error.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, powershell
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.