pnp / pnp/pnpframework

Upcoming Change on DenyAddAndCustomizePages

Open
#984 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
259
Forks
161
Avg merge
10h 33m
Merged PRs (30d)
1

Description

I did try to understand this change in respect of WebProperties in PNP-Templates:
https://admin.microsoft.com/AdminPortal/home?#/MessageCenter/:/messages/MC714186

Thinking about how to handle this in PnP-Framework as i currently see no alternative to Indexed WebProperties in order to promote additional Data about a Site to search. As the article does not mention WebProperties but they have been affected by the DenyAddAndCustomizePages setting i would think we have to handle this change in pnpframework.

My suggested fix would be to check on BaseSiteTemplate and existance of PropertyBagEntries in Template. If the Site Type is affected by the change and Entries exist i would set DenyAddAndCustomizePages to false. The way i understand the change MC714186 this setting will be reverted within 24 hours.

@jansenbe Before i start implement this change, i would like to know what are your thoughts on this?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked MC714186 announcement and the PnP-Templates handling of BaseSiteTemplate and PropertyBagEntries. Confirm which site types are affected and how DenyAddAndCustomizePages is currently applied; the change is done when the agreed behavior for templates with property bag entries is implemented and verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.