pnp / pnp/pnpframework

Sometimes the request to get channels from a new created Teams is not finishing

Open
#954 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
259
Forks
161
Avg merge
10h 33m
Merged PRs (30d)
1

Description

Basically for new installations where we are provisioning a Team with a channel, in this piece of code there is a line to get channels from method InitTeamDrive

try
{
channels = HttpHelper.MakeGetRequestForString($"{GraphHelper.MicrosoftGraphBaseURI}v1.0/teams/{teamId}/channels", accessToken);
if (!string.IsNullOrEmpty(channels))
{
wait = false;
}
}
catch (Exception)
{
Thread.Sleep(TimeSpan.FromSeconds(5));
}

if (iterations > 60)
{
throw new Exception($"Could not get channels for team with id {teamId} within timeout.");
}

The line in bold sometimes is not finishing and returning the exception which is bold as well. Not happening always. Do you think that the delay applied is enough? If the exception is triggered it means that it was trying during 5 mins, which I think is quite enough.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the InitTeamDrive entry point and the Microsoft Graph teams/{teamId}/channels request, including the retry loop and five-minute timeout described in the issue. Reproduce the intermittent hang during new Team provisioning and determine the expected behavior when the request does not finish; done should include a verified resolution for that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.