pnp / pnp/pnpframework

CanvasSection ->Collapsible Section needs SectionType=1 from pnp.core in order to have new section data saved

Open
#464 5 comments 0 reactions 1 assignee View on GitHub

@jansenbe is already working on this.

Since Sep 21, 2021.

Dominant language
C#
Stars
259
Forks
161
Avg merge
10h 33m
Merged PRs (30d)
1

Description

In order to get the new functionality around Collapsible Section from pnp.core to pnp.framework i did try to expand the
\pnpframework\src\lib\PnP.Framework\Provisioning\Model\SharePoint\ModernExperiences\CanvasSection.cs with the Properties from \pnpcore\src\sdk\PnP.Core\Model\SharePoint\Pages\public\ICanvasSection.cs.

That way i would be able to prepare for template support. Unfortunatelly the new sections settings are not saved if SectionType=0 but SectionType is only pnp.core internal, so it can not be set from pnp.framework.

@jansenbe: I could not see why SectionType should be private and not available in interface - ok to change or did you have an other idea to get this to pnpframework

Currently Collapsible Sections on a out-of-the-box site make webparts fail to load after colapse/expande multiple times. In Browserconsole you can see that PageContext is missing or DOM can not be read.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.