pnp / pnp/pnpframework

ShowSiteNavigation in pnp:Header is not being considered

Open
#396 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
259
Forks
161
Avg merge
10h 33m
Merged PRs (30d)
1

Description

Perhaps I don't understand what ShowSiteNavigation refers to but I when invoking a templating with ShowSiteNavigation set to false Site Navigation still shows up as shown in the attached screenshot.
I did not find another issue which mentioned the same issue.

Let me know if any additional information is needed!

Schermafbeelding 2021-06-30 om 15 37 46

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing a templating invocation with ShowSiteNavigation set to false and inspect the pnp:Header handling. Confirm the current behavior against the attached screenshot; done means Site Navigation no longer appears when the setting is false.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.