Centralise default config values
Open
Nobody has claimed this yet.
enhancement
help wanted
keep-open
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 413
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 21
Description
In a lot of commands, we retrieve config values as follows:
cli.getSettingWithDefaultValue<boolean>(settingsNames.autoOpenLinksInBrowser, false)
I don't think it's a good approach to define the default value in the command itself. A better approach would be that we centralize all default values and provide a new function where the user should only specify the config variable.
E.g.:
cli.getSetting<boolean>(settingsNames.autoOpenLinksInBrowser)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the command implementations for getSettingWithDefaultValue and the settingsNames definitions, starting with the autoOpenLinksInBrowser example. Determine where existing defaults are defined and how the proposed getSetting API would cover them; done means defaults are centralized and command-level default arguments are no longer needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100