Using util functions in favor of commands calling other commands to reuse code
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 413
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 21
Description
Like we explained in https://github.com/pnp/cli-microsoft365/discussions/4486, we're going to replace the pattern of commands calling other commands to centralizing the shared code in util functions and using utils where needed.
Following commands call other commands and need to be refactored:
- #5232
- #5234
- #6679
- #5236
- #5238
- #5240
- #5242
- #5244
- #6673
- #5246
- #5248
- #5250
- #5252
- #5254
- Refactor 'spo applicationcustomizer add' to use util instead of calling other command
- #5256
- #5258
- #5260
- #5262
- #5264
- #5266
- #5270
- #5272
- #5274
- #5276
- #5278
- #5280
- #5282
- #5284
- Refactor 'spo group member add' to use util instead of calling other command
- #5286
- #5157
- #5158
- #5292
- #5294
- #5296
- #5298
- #5300
- #5303
- #5305
- #5306
- #5307
- #5308
- #5310
- #5312
- #5316
- #5318
- #5320
- #5322
- #5324
- #5290
- #5288
- #5268
- #5314
- #5309
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with discussion #4486 and the unchecked work items, especially the entries for 'spo applicationcustomizer add' and 'spo group member add'. Review the affected command implementations and identify shared logic that can be centralized in util functions. Done means the remaining listed commands no longer call other commands and use the shared utilities instead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100