Consolidate user options in different commands
Open
Nobody has claimed this yet.
enhancement
keep-open
needs research
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 413
- Avg merge
- 5d 6h
- Merged PRs (30d)
- 21
Description
We have several commands that allow to input user information but not all provide the same parameters:
If we look at teams channel member add we use a userId and userDisplayName. If we look at aad user get we provide id, userName, email and for yammer group list we only support userId.
- We should investigate what commands require user imput
- We should provide a helper method to get a
useridbased onemailso we can re-use that in all commands - We should upgrade all commands to provide support for
userId,userDisplayNameandemail
Follows discussion on #3899
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying commands that accept user information, including teams channel member add, aad user get, and yammer group list, then review discussion #3899. Done means providing a reusable helper to resolve a userId from email and aligning the affected commands around userId, userDisplayName, and email.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100