CSM Shader broken
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 858
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
threeversion: 0.170.0@types/threeversion: 0.170.0three-stdlibversion: 2.34.0
Problem description:
Creating the CSM fails with the following error: Can not resolve #include <lights_pars_begin>
The original library broke with three 157, see issue and PR, but isn't receiving updates anymore from what it looks like. Would be nice to have a working version in here, not sure if these fixes apply in the same way (original library errors in a different way).
Relevant code:
const csm = new CSM({
maxFar: camera.far,
cascades: 4,
shadowMapSize: 1024,
lightDirection: new Vector3(0, -1, 0).normalize(),
camera: camera,
parent: scene
});
const material = new THREE.MeshStandardMaterial(); // works with Phong and Standard materials
csm.setupMaterial(material); // must be called to pass all CSM-related uniforms to the shader
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the failure with three 0.170.0 using the CSM constructor and setupMaterial call shown in the issue. Review the CSM shader path alongside the linked upstream issue and PR, then verify that MeshStandardMaterial and Phong materials no longer fail to resolve the lights_pars_begin include.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100