Expected publicly documented methods of ArcballControls to be public
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 858
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
threeversion: ^0.164.1@types/threeversion: ^0.164.1three-stdlibversion: ^2.30.1
Problem description:
Many public and documented methods on ArcballControls are marked private in three-stdlib.
Relevant code:
...
Suggested solution:
Replace the private access modifier with public.
Are these marked private intentionally?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/controls/ArcballControls.ts around the private declarations near line 1487 and compare them with the public methods documented in the linked three.js ArcballControls source and API documentation. Done means the documented ArcballControls methods have public access in three-stdlib's TypeScript declarations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js, typescript
- Domain
- api, frontend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100