wrong type in defaultColor in OutlineEffect
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 858
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
threeversion: 0.150.1@types/threeversion: 0.163three-stdlibversion: 2.33.0
Problem description:
defaultColor in OutlineEffectParameters for the OutlineEffect class is set to number[]. It should probably be Color
Relevant code:
export interface OutlineEffectParameters {
defaultThickness?: number | undefined
defaultColor?: number[] | undefined
defaultAlpha?: number | undefined
defaultKeepAlive?: boolean | undefined
}
Suggested solution:
Change it to be Color type.
Thank you for providing this library for us developers.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the OutlineEffectParameters definition and inspect how defaultColor is typed and used by OutlineEffect. Change the parameter type to Color, then verify that the declaration accepts the intended value and that the project's relevant type checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js, typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100