`onBeforeRender` of `Reflector` & `Refractor` type is mismatched
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 858
- Forks
- 144
- PR merge metrics
- No merged PRs in 30d
Description
threeversion: 0.160.0@types/threeversion: 0.162.0three-stdlibversion: 2.29.4
Problem description:
I receive this parameters type errors for Reflector and Refractor, where it should have accept 3 parameters instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the type declarations and implementations for Reflector and Refractor in three-stdlib, then compare their onBeforeRender signatures with the three and @types/three versions listed. Done means the callback accepts the intended three parameters without TypeScript errors; verify with the repository's available type-checking or test command.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js, typescript
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100