[bug]: type error: animated group rotation prop does not accept array or euler object
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 29.1k
- Forks
- 1.2k
- PR merge metrics
- No merged PRs in 30d
Description
Which react-spring target are you using?
-
@react-spring/web -
@react-spring/three -
@react-spring/native -
@react-spring/konva -
@react-spring/zdog
What version of react-spring are you using?
9.7.4
What's Wrong?
When I use spring to animate the rotation of a three.js object, typescript throws a type error when the rotation prop is provided as an array while using the position prop works as expected with an array but applying the same logic to rotation results in a type mismatch.
To Reproduce
Here is a simple example
import { animated, useSpring } from '@react-spring/three';
import { Box } from '@react-three/drei';
import { Canvas } from '@react-three/fiber';
import { useState } from 'react';
const RotatingCube = () => {
const [clicked, setClicked] = useState(false);
// Define spring for position and rotation
const { position, rotation } = useSpring({
position: [0, 0, 0] as const, // Static position
rotation: clicked ?
([Math.PI / 4, Math.PI / 4, 0] as const)
: ([Math.PI / 2, Math.PI / 4, 0] as const)
});
return (
<animated.group
position={position}
rotation={rotation} // This triggers the type error
>
<Box onClick={() => setClicked((clicked) => !clicked)}>
<meshStandardMaterial attach="material" color="orange" />
</Box>
</animated.group>
);
};
const Root = () => {
return (
<Canvas>
<ambientLight />
<pointLight position={[10, 10, 10]} />
<RotatingCube />
</Canvas>
);
};
export default Root;
Expected Behaviour
I expect the code to compile with no issues since it also works at runtime.
Link to repo
See To Reproduce section
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the @react-spring/three animated group prop typings and compare how position and rotation arrays are represented. Use the TypeScript reproduction in the issue to verify the mismatch; done means the shown rotation prop compiles without an error while preserving the existing runtime behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, three.js, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100