pmndrs / pmndrs/react-spring

[feat]: Parallax page should be able to be sized by pixels or a constant and not just viewHeight.

Open
#2,188 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

template: request
Dominant language
TypeScript
Stars
29.1k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

A clear and concise description of what the feature is

Looking at the ParallaxLayer component and specifically the factor prop. I feel a user should instead of just being able to use a multiple of the user's window height to size a page, there should be an option to have a page set to a constant.

Why should this feature be included?

I have a multi page website, but my second page has text information on it, that should not look different on any device. However, my other pages are all set to 100% window height.

Please provide an example for how this would work

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the ParallaxLayer component and inspect how its factor prop currently sizes pages from the view height. Determine the supported constant or pixel-sizing behavior and verify that existing viewHeight-based usage remains unchanged; the issue provides no example, file path, or test target.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.