pmndrs / pmndrs/react-spring

re-add onDelayEnd function

Open
#1,579 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

kind: request
Dominant language
TypeScript
Stars
29.1k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

🐛 Bug Report

The title says it all, but for reference: https://github.com/pmndrs/react-spring/commit/f8a54c5c6ed66b1e4c02bfff152e40ce8470f967

Why was it removed?

And why isn't the documentation updated to remove the event reference...

Environment

  • react-spring v9.2.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the removal commit f8a54c5c6ed66b1e4c02bfff152e40ce8470f967 with the current react-spring event API, then inspect the documentation reference to onDelayEnd. Determine whether the function should be restored and whether its documentation should be updated; the issue provides no file or test path.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
documentation, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.