pmndrs / pmndrs/postprocessing

Implement DepthOfFieldEffect

Open
#569 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
251
Avg merge
17m
Merged PRs (30d)
1

Description

Description

Implement a DepthOfFieldEffect based on the implementation in v6.

References:

Tasks
  • Create CoC shader.
  • Create blur shader.
  • Create DepthOfFieldEffect.
  • Create depth-of-field demo.
  • Add unit test.
Implementation Details
  • Check the linked article for potential improvements.
  • Should be done after PoissonBlurMaterial has been implemented.
  • The CoC should be calculated based on fragment distance instead of depth.
  • Add support for logarithmic depth.
  • Consider adding options for fringe/chromatic aberration and luminance gain.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the v6 DepthOfFieldEffect.js implementation and checking the PoissonBlurMaterial prerequisite. Then review the shader, effect, depth-of-field demo, and unit-test entry points named in the task list; done means all five tasks are implemented, including distance-based CoC, logarithmic depth support, and passing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, three.js
Domain
computer-graphics
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.