Type error in the EcctrlJostick.tsx file
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 797
- Forks
- 98
- Avg merge
- 8m
- Merged PRs (30d)
- 1
Description
I found typing issues in the EcctrlJostick.tsx file. Buttons of type THREE.CylinderGeometry are not compatible with the geometry parameter of the mesh component; geometry is of type BufferGeometry | Readonly<BufferGeometry. The same thing happens with the material property.
Example:
<mesh geometry={buttonLargeBaseGeo} material={buttonBaseMaterial} ... />
Similarly, when searching for elements in the DOM, they may be null.
Example:
const buttonDiv: HTMLDivElement = document.querySelector("#ecctrl-button")
I'm using Next.js version 15.3.2 and the ecctrl library 1.0.92.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open EcctrlJostick.tsx and run the project's TypeScript check to inspect the geometry, material, and DOM query errors described in the issue. Done means the reported assignments and possible null result are accepted by TypeScript without introducing new errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, three.js, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100