pmndrs / pmndrs/ecctrl

React 19

Open
#132 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
797
Forks
98
Avg merge
8m
Merged PRs (30d)
1

Description

Hi,

Can you please update to React 19?

Error:

chunk-KNK3UTB7.js?v=ae6950dd:5305 Uncaught TypeError: import_react_dom6.default.render is not a function
    at render (ecctrl.js?v=ae6950dd:5923:29)
    at ecctrl.js?v=ae6950dd:11460:11
    at react-stack-bottom-frame (chunk-HQOX6EPQ.js?v=ae6950dd:10257:20)
    at runWithFiberInDEV (chunk-HQOX6EPQ.js?v=ae6950dd:638:18)
    at commitHookEffectListMount (chunk-HQOX6EPQ.js?v=ae6950dd:6678:123)
    at commitHookPassiveMountEffects (chunk-HQOX6EPQ.js?v=ae6950dd:6736:60)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8137:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8175:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
The error message import_react_dom6.default.render is not a function indicates that the ecctrl library is trying to use the legacy ReactDOM.render() method, which has been removed in React 18 and above. In React 18+, the recommended way to render is using createRoot.

The R3F already is using version 19:
https://github.com/pmndrs/react-three-fiber/blob/master/package.json

Thanks.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare this repository's React dependency with the React Three Fiber package.json linked in the issue, then locate the ecctrl.js render call shown in the stack trace. Reproduce the failure with React 19 and verify that the controller works without the reported render error.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.