pmndrs / pmndrs/ecctrl

bug: needs a way to supply followLight DirectionalLight object

Open
#119 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
797
Forks
98
Avg merge
8m
Merged PRs (30d)
1

Description

this code

      dirLight = characterModelRef.current.parent.parent.children.find(

assumes the directionalLight is at a specific level, Ecctrl might be lower in the components tree.
Can we supply a ref somehow, through context maybe?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the directional-light lookup shown in the issue and inspect how Ecctrl accesses the character model's parent hierarchy. Determine how a DirectionalLight ref could be supplied without assuming a fixed tree depth; done means the light can be provided explicitly and the existing lookup no longer depends on that hierarchy.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, three.js, typescript
Domain
frontend, game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.