Wrong "device" name
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Description
Hello, thanks for this awesome tool for three.js but I found a little bug in my mobile phone.
I'm using "Samsung Galaxy S21 Ultra" but the live demo page in the README.md says the device it is "huawei mate 40 pro 5g". It's really wrong but probably it's guessed it from the GPU model because both that Huawei's SoC and S21U's SoC has same "ARM Mali-G78" gpu.
I think rather then guessing the phone it'll be more accurate to just leave the GPU model with device specific display info. Or this guessing algorithm needed to change with better one with some values to stand on more then just GPU model and display info. Because nearly all SoC other then Qualcomm ones uses Mali GPUs in Android devices and this can cause really trouble to developers who didn't get this bug while developing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the live demo referenced in README.md and trace how it produces the reported device name from the available GPU and display information. Compare the output for the Samsung Galaxy S21 Ultra and Huawei Mate 40 Pro 5G cases, then define and verify detection behavior that avoids misleading device identification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js, typescript
- Domain
- computer-graphics, web-dev
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100