plus3it / plus3it/chrome-browser-formula
Fix Parameter Processing
Open
Nobody has claimed this yet.
- Dominant language
- Jinja
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Installations currently failing due to several issues:
- The
config/clean.sls,config/file.sls,config/lin_clean.sls,config/lin_file.sls,config/win_clean.sls,config/win_file.sls,package/lin_clean.sls,package/win_install.sls,package/win_post-install.sls,package/win_pre-install.sls,package/lin_install.sls,service/clean.sls,service/running.sls,subcomponent/config/clean.slsandsubcomponent/config/file.slsfiles all bind parameters aschromerather thanchrome-browser
This should be:{%- from tplroot ~ "/map.jinja" import mapdata as chrome with context %}
To match Pillar expectations{%- from tplroot ~ "/map.jinja" import mapdata as chrome_browser with context %} - Change all
chrome.*references tochrome_browserreferences. This effects:package/lin_clean.slspackage/win_clean.slspackage/win_install.slspackage/lin_install.slsconfig/lin_clean.slsconfig/lin_file.slsconfig/win_clean.slsconfig/win_file.sls
- Fix
package/lin_install.sls.- If installing from URI, needs both
nameparameter (referencingchrome_browser.pkg.release_family) and asourcesparameter (referencingchrome_browser.pkg.installer_uri). - If installing from standard repository, only needs
nameparameter - Wants an (optional) install of a repository-definition file
- If installing from URI, needs both
- While we're here, superfluous state-trees should be nuked. Kill the
serviceandsubcomponentdirectories and remove references from fomula-root'sinit.sls
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the listed config/.sls and package/.sls files together with the formula-root init.sls, then trace how each state binds and references the pillar data. Done means all bindings and references use chrome_browser, Linux installation supports both URI and repository paths with the optional repository-definition file, and the service and subcomponent trees are removed with their references.
Written by the indexing model from the issue text.
Assessment
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100