plus3it / plus3it/chrome-browser-formula

Fix Parameter Processing

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jinja
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Installations currently failing due to several issues:

  • The config/clean.sls, config/file.sls, config/lin_clean.sls, config/lin_file.sls, config/win_clean.sls, config/win_file.sls, package/lin_clean.sls, package/win_install.sls, package/win_post-install.sls, package/win_pre-install.sls, package/lin_install.sls, service/clean.sls, service/running.sls, subcomponent/config/clean.sls and subcomponent/config/file.sls files all bind parameters as chrome rather than chrome-browser
    {%- from tplroot ~ "/map.jinja" import mapdata as chrome with context %}
    
    This should be:
    {%- from tplroot ~ "/map.jinja" import mapdata as chrome_browser with context %}
    
    To match Pillar expectations
  • Change all chrome.* references to chrome_browser references. This effects:
    • package/lin_clean.sls
    • package/win_clean.sls
    • package/win_install.sls
    • package/lin_install.sls
    • config/lin_clean.sls
    • config/lin_file.sls
    • config/win_clean.sls
    • config/win_file.sls
  • Fix package/lin_install.sls.
    • If installing from URI, needs both name parameter (referencing chrome_browser.pkg.release_family) and a sources parameter (referencing chrome_browser.pkg.installer_uri).
    • If installing from standard repository, only needs name parameter
    • Wants an (optional) install of a repository-definition file
  • While we're here, superfluous state-trees should be nuked. Kill the service and subcomponent directories and remove references from fomula-root's init.sls

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the listed config/.sls and package/.sls files together with the formula-root init.sls, then trace how each state binds and references the pillar data. Done means all bindings and references use chrome_browser, Linux installation supports both URI and repository paths with the optional repository-definition file, and the service and subcomponent trees are removed with their references.

Written by the indexing model from the issue text.

Assessment

Domain
devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.